Remove File Plugin #1521
Merged
aphralG merged 11 commits intorefactor-instance-watcherfrom Feb 23, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor-instance-watcher #1521 +/- ##
============================================================
Coverage ? 84.85%
============================================================
Files ? 102
Lines ? 13466
Branches ? 0
============================================================
Hits ? 11427
Misses ? 1523
Partials ? 516
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dhurley
reviewed
Feb 16, 2026
internal/nginx/nginx_plugin.go
Outdated
| } | ||
| n.nginxService.UpdateResource(ctx, resourceUpdate) | ||
| slog.DebugContext(ctx, "Nginx plugin received update resource message") | ||
| slog.DebugContext(ctx, "NginxPlugin plugin received update resource message") |
Collaborator
There was a problem hiding this comment.
Suggested change
| slog.DebugContext(ctx, "NginxPlugin plugin received update resource message") | |
| slog.DebugContext(ctx, "NGINX plugin received update resource message") |
Probably should update other similar debug messages
internal/nginx/nginx_plugin.go
Outdated
| } | ||
| case bus.ConnectionCreatedTopic: | ||
| if logger.ServerType(ctxWithMetadata) == n.serverType.String() { | ||
| slog.DebugContext(ctxWithMetadata, "Resource plugin received connection created message") |
Collaborator
There was a problem hiding this comment.
Suggested change
| slog.DebugContext(ctxWithMetadata, "Resource plugin received connection created message") | |
| slog.DebugContext(ctxWithMetadata, "NGINX plugin received connection created message") |
internal/nginx/nginx_plugin.go
Outdated
| n.handleConfigApplyRequest(ctxWithMetadata, msg) | ||
| } | ||
| default: | ||
| slog.DebugContext(ctx, "Unknown topic", "topic", msg.Topic) |
Collaborator
There was a problem hiding this comment.
Suggested change
| slog.DebugContext(ctx, "Unknown topic", "topic", msg.Topic) | |
| slog.DebugContext(ctx, "NGINX plugin received message from unknown topic", "topic", msg.Topic) |
internal/nginx/nginx_plugin.go
Outdated
| func (n *Nginx) Reconfigure(ctx context.Context, agentConfig *config.Config) error { | ||
| slog.DebugContext(ctx, "Nginx plugin is reconfiguring to update agent configuration") | ||
| func (n *NginxPlugin) Reconfigure(ctx context.Context, agentConfig *config.Config) error { | ||
| slog.DebugContext(ctx, "NginxPlugin plugin is reconfiguring to update agent configuration") |
Collaborator
There was a problem hiding this comment.
Suggested change
| slog.DebugContext(ctx, "NginxPlugin plugin is reconfiguring to update agent configuration") | |
| slog.DebugContext(ctx, "NGINX plugin is reconfiguring to update agent configuration") |
internal/nginx/nginx_plugin.go
Outdated
| "github.com/nginx/agent/v3/internal/config" | ||
| response "github.com/nginx/agent/v3/internal/datasource/proto" | ||
| "github.com/nginx/agent/v3/internal/file" | ||
| grpc2 "github.com/nginx/agent/v3/internal/grpc" |
Collaborator
There was a problem hiding this comment.
do you have to name this import grpc2? I dont think it is conflicting with any other import.
internal/nginx/nginx_plugin.go
Outdated
| n.reloadSuccessful(ctx, configContext, dpResponse) | ||
| } | ||
|
|
||
| func (n *NginxPlugin) failedConfigApply(ctx context.Context, correlationID, instanceID string, applyErr error) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| func (n *NginxPlugin) failedConfigApply(ctx context.Context, correlationID, instanceID string, applyErr error) { | |
| func (n *NginxPlugin) rollbackConfigApply(ctx context.Context, correlationID, instanceID string, applyErr error) { |
internal/nginx/nginx_plugin.go
Outdated
|
|
||
| n.agentConfigMutex.Lock() | ||
| defer n.agentConfigMutex.Unlock() | ||
| func (n *NginxPlugin) reloadSuccessful(ctx context.Context, |
Collaborator
There was a problem hiding this comment.
I wonder would it be possible to combine the reloadSuccessful & completeConfigApply into one function?
dhurley
approved these changes
Feb 18, 2026
Akshay2191
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)