Skip to content

Remove File Plugin #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aphralG merged 11 commits into from
Feb 23, 2026
Merged

Remove File Plugin #1521

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
59ac30f
WIP remove file plugin
aphralG Feb 12, 2026
5af1147
WIP remove file plugin
aphralG Feb 12, 2026
df31f59
fix tests
aphralG Feb 12, 2026
9ecb92d
fix tests
aphralG Feb 12, 2026
ec2984e
add tests
aphralG Feb 16, 2026
c05a13e
fix tests
aphralG Feb 16, 2026
173e07e
PR feedback
aphralG Feb 16, 2026
cef67fc
clean up
aphralG Feb 16, 2026
af9600b
clean up
aphralG Feb 16, 2026
2837017
fix tests
aphralG Feb 17, 2026
bb8cc1e
clean up
aphralG Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions internal/bus/topics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@ const (
ConnectionResetTopic = "connection-reset"
ConfigApplyRequestTopic = "config-apply-request"
WriteConfigSuccessfulTopic = "write-config-successful"
ReloadSuccessfulTopic = "reload-successful"
EnableWatchersTopic = "enable-watchers"
ConfigApplyFailedTopic = "config-apply-failed"
ConfigApplyCompleteTopic = "config-apply-complete"
RollbackWriteTopic = "rollback-write"
DataPlaneHealthRequestTopic = "data-plane-health-request"
DataPlaneHealthResponseTopic = "data-plane-health-response"
APIActionRequestTopic = "api-action-request"
Expand Down
4 changes: 2 additions & 2 deletions internal/file/file_manager_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
//counterfeiter:generate . fileOperator

//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6@v6.8.1 -generate
//counterfeiter:generate . fileManagerServiceInterface
//counterfeiter:generate . FileManagerServiceInterface

//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6@v6.8.1 -generate
//counterfeiter:generate . fileServiceOperatorInterface
Expand Down Expand Up @@ -86,7 +86,7 @@ type (
UpdateClient(ctx context.Context, fileServiceClient mpi.FileServiceClient)
}

fileManagerServiceInterface interface {
FileManagerServiceInterface interface {
ConfigApply(ctx context.Context, configApplyRequest *mpi.ConfigApplyRequest) (writeStatus model.WriteStatus,
err error)
Rollback(ctx context.Context, instanceID string) error
Expand Down
Loading
Loading