Skip to content

fix: Ensure stream closed #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattdesmarais wants to merge 3 commits into from
Closed

fix: Ensure stream closed #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ba184c
fix: ensure stream is closed and wait for server response
Feb 12, 2026
6bef50b
fix: ensure stream is closed and wait for server response
Feb 12, 2026
7b910ae
Fix Integration Tests (#1523)
aphralG Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/file/file_service_operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,11 @@ func (fso *FileServiceOperator) sendFileUpdateStreamChunks(
chunkID++
}

return nil
// Ensure the stream is closed and wait for the server's response only
// after all chunks are sent
_, err = updateFileStreamClient.CloseAndRecv()

return err
}

func (fso *FileServiceOperator) sendFileUpdateStreamChunk(
Expand Down
2 changes: 2 additions & 0 deletions test/mock/grpc/mock_management_file_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@ func (mgs *FileService) UpdateFileStream(streamingServer grpc.ClientStreamingSer
return writeChunkedFileError
}

streamingServer.SendAndClose(&v1.UpdateFileResponse{})

return nil
}

Expand Down
Loading