-
Notifications
You must be signed in to change notification settings - Fork 54
NGINXaaS Custom Security Policies #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
Did a quick grep on where we refer to NAP as being in preview. Please change the following:
|
Don't forget to call out anything in the official docs that cannot be done with the Saas version (a few general exceptions are mentioned in the NLB-5567 ticket). |
They might not be available yet, but should we have a section for the CLI tool, as well as Terraform? |
Another thought I had given the current incident reported by Liftr is that we should highly suggest they enable NGINX Security Logs (in the Diagnostic settings for Portal users). |
672acd9
to
57c913d
Compare
Still missing a Troubleshooting section for NAP |
57c913d
to
0b9d2fc
Compare
|
||
{{< img src="nginxaas-azure/custom-policy-editor.png" alt="NGINXaaS Custom Policy Editor." >}} | ||
|
||
After your policy has been saved, you can then reference it in your NGINX configuration the same as you did for precompiled policies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After your policy has been saved, you can then reference it in your NGINX configuration the same as you did for precompiled policies. | |
After your policy has been saved, you can then reference it in your NGINX configuration as you did before for precompiled policies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes the customer used precompiled policies previously. We shouldn't make this assumption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed mention of precompiled polcies.
Updated doc to support the use of NGINX App Protect custom security policies.
0b9d2fc
to
1cc1fd0
Compare
@edarzins please review the conflicts with the target branch (another PR updated the changelog too) |
@JTorreG - please approve this MR if there are no specific changes needed besides rebasing. The pipeline will automatically block the merge until the conflicts are resolved and there will probably be multiple rebases needed. We want to be in a position that when the production code is live we can push the docs too. |
Updated doc to support the use of NGINX App Protect custom security policies.
Proposed changes
Update NGINXaaS for Azure doc to support NGINX App Protect custom policies
Problem: Document new feature for NGINXaaS for Azure
Solution: N/A
Testing: N/A
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩