Skip to content

fix: N1C. Help users look for "out of sync" Instances in a CSG #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Apr 16, 2025

Proposed changes

Help users understand -- just because you add an Instance to a CSG, they don't automatically sync

Closes #420

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@mjang mjang requested a review from a team as a code owner April 16, 2025 18:26
@mjang mjang self-assigned this Apr 16, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels Apr 16, 2025
@mjang mjang changed the title N1C. Help users look for "out of sync" Instances in a CSG fix: N1C. Help users look for "out of sync" Instances in a CSG Apr 16, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/422/

@mjang mjang requested review from jasonclopper and sylwang April 16, 2025 18:47
@@ -100,6 +100,9 @@ Now that you created a Config Sync Group, you can add instances to that group. A

Any instance that joins the group afterwards inherits that configuration.

{{< note >}} If there are conflicts between an instance and the Config Sync Group, you'll see the following [Config Sync Group Status](#config-sync-group-status) message: **Out of Sync**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an instance is out of sync, it wouldn't necessarily be because there is a conflict between the instance and the CSG, it's usually due to some errors in the NGINX configuration that is either not caught when users created the CSG, or something has gone wrong on the data plane instance.

Here is roughly what I think that could be helpful to include in this part of the doc:

Suggested change
{{< note >}} If there are conflicts between an instance and the Config Sync Group, you'll see the following [Config Sync Group Status](#config-sync-group-status) message: **Out of Sync**.
{{< note >}} If there was any failure while synchronizing the instance's configuration with the Config Sync Group, you'll see the following [Config Sync Group Status](#config-sync-group-status) message: **Out of Sync**. In that case, check the instance details to see its latest publication and the failure cause. You might need to modify the configuration on the Config Sync Group to fix configuration related errors, and you can publish an updated configuration for the Config Sync Group which should re-synchronize the instance.

Feel free to make any changes as you see fit!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like far too much information to throw into a note: might feel better once it's had an edit pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylwang wdyt?

Suggested change
{{< note >}} If there are conflicts between an instance and the Config Sync Group, you'll see the following [Config Sync Group Status](#config-sync-group-status) message: **Out of Sync**.
{{< note >}} If you see the following [Config Sync Group Status](#config-sync-group-status) message: **Out of Sync**:
- Review the instance. NGINX One Console can help you identify problems.
- After you change the configuration of the instance or Config Sync Group, [Publish it](#publish-the-config-sync-group-configuration].

@@ -100,6 +100,9 @@ Now that you created a Config Sync Group, you can add instances to that group. A

Any instance that joins the group afterwards inherits that configuration.

{{< note >}} If there are conflicts between an instance and the Config Sync Group, you'll see the following [Config Sync Group Status](#config-sync-group-status) message: **Out of Sync**.
In that case, review and resolve discrepencies between the Instance and the rest of the Config Sync Group. {{< /note >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In that case, review and resolve discrepencies between the Instance and the rest of the Config Sync Group. {{< /note >}}
In that case, review and resolve discrepancies between the Instance and the rest of the Config Sync Group. {{< /note >}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

N1C, when adding instances to a CSG
3 participants