Skip to content

Update managing-configuration-files.md #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2025
Merged

Conversation

RMDavidson
Copy link
Contributor

Removed an extra space before a comma and made changes for clarity, e.g. changed one to context, in a server to within a server (for consistency with text usage above), etc.

Reload Configuration felt odd since you wouldn't say "...without reload the configuration." in the text below so I left it like you would with Troubleshooting in some instances. Maybe if it said "Reload the Configuration file" that would work.

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

Removed extra space before comma and made changes for clarity, e.g. one to context, in a server to within a server (for consistency with text usage above), etc.

Reload Configuration felt odd since you wouldn't say "...without reload the configuration." in the text below so I left it like you would with Troubleshooting in some instances. Maybe if it said "Reload the Configuration file" that would work.
@RMDavidson RMDavidson requested a review from a team as a code owner April 16, 2025 18:55
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) labels Apr 16, 2025
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some small edit suggestions, with context around them - they're things covered by guidance we have available that we proactively address whenever we work on pages.

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ADubhlaoich I pushed your changes -- as LGTM, but beyond scope for the PR.

@mjang
Copy link
Contributor

mjang commented Apr 17, 2025

@RMDavidson congratulations on another contribution! And for your patience with our reviews :)

@mjang mjang merged commit 77939c1 into nginx:main Apr 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants