generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 54
fix: minimize reference to metrics #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjang
commented
Apr 16, 2025
mjang
commented
Apr 16, 2025
✅ Deploy Preview will be available once build job completes!
|
ADubhlaoich
approved these changes
Apr 17, 2025
mjang
commented
Apr 17, 2025
jasonclopper
approved these changes
Apr 17, 2025
travisamartin
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The change in this PR is "simpler than it looks", as we had set up variables to include the same content for N+ as we do for NIM
So I link to the production doc section, and the proposed change with the build:
Based on feedback. Short version, the words in our current doc suggest more metrics than we deliver.
Doc note: as this is currently based on common content with https://docs.nginx.com/nginx-instance-manager/monitoring/overview-metrics/#f5-nginx-plus-metrics, I have disabled the "include" functionality that (essentially) copies that content.
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩