Skip to content

fix: minimize reference to metrics #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 17, 2025
Merged

fix: minimize reference to metrics #426

merged 8 commits into from
Apr 17, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Apr 16, 2025

Proposed changes

The change in this PR is "simpler than it looks", as we had set up variables to include the same content for N+ as we do for NIM

So I link to the production doc section, and the proposed change with the build:

Based on feedback. Short version, the words in our current doc suggest more metrics than we deliver.

Doc note: as this is currently based on common content with https://docs.nginx.com/nginx-instance-manager/monitoring/overview-metrics/#f5-nginx-plus-metrics, I have disabled the "include" functionality that (essentially) copies that content.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@mjang mjang requested review from a team as code owners April 16, 2025 21:20
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels Apr 16, 2025
@mjang mjang self-assigned this Apr 16, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/426/

@mjang mjang requested a review from jasonclopper April 17, 2025 14:34
@mjang mjang merged commit af8a62b into main Apr 17, 2025
9 checks passed
@mjang mjang deleted the fix-n1c-metric-details branch April 17, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants