Skip to content

Add telemetry support for Native OIDC - #10624

Open
spencerugbo wants to merge 1 commit into
feat/native-oidc-ingressfrom
feat/native-oidc-telemetry
Open

Add telemetry support for Native OIDC#10624
spencerugbo wants to merge 1 commit into
feat/native-oidc-ingressfrom
feat/native-oidc-telemetry

Conversation

@spencerugbo

@spencerugbo spencerugbo commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Add OIDC Native policy to telemetry data

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copilot AI lite review requested due to automatic review settings August 13, 2026 10:08
@spencerugbo
spencerugbo requested a review from a team as a code owner August 13, 2026 10:08
@github-actions github-actions Bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels Aug 13, 2026
@spencerugbo spencerugbo changed the title add telemetry support for native oidc Add telemetry support for Native OIDC Aug 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds telemetry reporting for the “Native OIDC” Policy type by counting spec.oidcNative policies and exporting the resulting count as part of NIC resource count telemetry.

Changes:

  • Extend policy counting to include OIDCNative policies and propagate the count through ReportNICResourceCounts.
  • Export the new OIDCNativePolicies value as an OpenTelemetry attribute and in the Avro IDL schema.
  • Add/extend unit tests to cover OIDCNative policy counting and reporting.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/telemetry/nicresourcecounts_attributes_generated.go Adds OIDCNativePolicies to exported OTel attributes for resource counts.
internal/telemetry/exporter.go Extends NICResourceCounts with OIDCNativePolicies.
internal/telemetry/data.avdl Updates telemetry schema (IDL) to include OIDCNativePolicies.
internal/telemetry/collector.go Wires OIDCNative policy count into report building and exported telemetry payload.
internal/telemetry/collector_test.go Adds test coverage for OIDCNative policy counting and inclusion in reported resource counts.
internal/telemetry/cluster.go Counts policies with spec.OIDCNative != nil under the OIDCNative key.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code

Projects

Status: Todo ☑

Development

Successfully merging this pull request may close these issues.

Enable Native OIDC Authentication for NGINX Ingress Controller using the NGINX Plus module

2 participants