Add telemetry support for Native OIDC - #10624
Open
spencerugbo wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds telemetry reporting for the “Native OIDC” Policy type by counting spec.oidcNative policies and exporting the resulting count as part of NIC resource count telemetry.
Changes:
- Extend policy counting to include
OIDCNativepolicies and propagate the count throughReport→NICResourceCounts. - Export the new
OIDCNativePoliciesvalue as an OpenTelemetry attribute and in the Avro IDL schema. - Add/extend unit tests to cover
OIDCNativepolicy counting and reporting.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/telemetry/nicresourcecounts_attributes_generated.go | Adds OIDCNativePolicies to exported OTel attributes for resource counts. |
| internal/telemetry/exporter.go | Extends NICResourceCounts with OIDCNativePolicies. |
| internal/telemetry/data.avdl | Updates telemetry schema (IDL) to include OIDCNativePolicies. |
| internal/telemetry/collector.go | Wires OIDCNative policy count into report building and exported telemetry payload. |
| internal/telemetry/collector_test.go | Adds test coverage for OIDCNative policy counting and inclusion in reported resource counts. |
| internal/telemetry/cluster.go | Counts policies with spec.OIDCNative != nil under the OIDCNative key. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add OIDC Native policy to telemetry data
Checklist
Before creating a PR, run through this checklist and mark each as complete.