-
Notifications
You must be signed in to change notification settings - Fork 2k
Clean up Agent values file and tests #7758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7758 +/- ##
=======================================
Coverage 52.34% 52.34%
=======================================
Files 89 89
Lines 21373 21373
=======================================
Hits 11188 11188
Misses 9719 9719
Partials 466 466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -4,6 +4,7 @@ | |||
|
|||
|
|||
@pytest.mark.skip_for_nginx_oss | |||
@pytest.mark.appprotect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this marker will cause a repeat of test in appprotect suite run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was actually meant to remove agent marker and change it to app protect so ill change that once we get the other images in.
Signed-off-by: AlexFenlon <[email protected]>
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.