Skip to content

Clean up Agent values file and tests #7758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented May 7, 2025

Proposed changes

  • add agent v2 helm tests
  • clean up agent values.yaml
  • remove fatal from flag for future reference

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner May 7, 2025 14:16
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests helm_chart Pull requests that update the Helm Chart labels May 7, 2025
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.34%. Comparing base (fb44688) to head (58ed68a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7758   +/-   ##
=======================================
  Coverage   52.34%   52.34%           
=======================================
  Files          89       89           
  Lines       21373    21373           
=======================================
  Hits        11188    11188           
  Misses       9719     9719           
  Partials      466      466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vepatel
vepatel previously approved these changes May 8, 2025
@AlexFenlon AlexFenlon moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller May 8, 2025
@AlexFenlon AlexFenlon self-assigned this May 8, 2025
@@ -4,6 +4,7 @@


@pytest.mark.skip_for_nginx_oss
@pytest.mark.appprotect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this marker will cause a repeat of test in appprotect suite run

Copy link
Contributor Author

@AlexFenlon AlexFenlon May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was actually meant to remove agent marker and change it to app protect so ill change that once we get the other images in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart python Pull requests that update Python code tests Pull requests that update tests
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

3 participants