Skip to content

Add labels to NAP pytest and add pull policy to Minikube local tests #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add labels to NAP pytest and add pull policy to Minikube local tests #7759

wants to merge 1 commit into from

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

  • allow setting of pull policy for minikube tests
  • add more app protect labels

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner May 7, 2025 14:21
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels May 7, 2025
@AlexFenlon AlexFenlon moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller May 8, 2025
@AlexFenlon AlexFenlon self-assigned this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@AlexFenlon AlexFenlon

Labels
python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: In Review 👀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexFenlon @pdabelf5