Reimplement DNS identifier validation. #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR reimplements DNS identifier validation to maintain compatibility with NGINX 1.29.4, which changed the signature of ngx_http_validate_host. Instead of adapting with version checks, the validation is now implemented directly in the module.
Key changes:
- Custom DNS identifier validation adhering to RFC 1123 with support for wildcards and underscore characters
- Support for wildcard DNS identifiers (e.g.,
*.example.com) - Minimum supported NGINX version updated from 1.25.0 to 1.22.0
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/conf/order.rs | Replaces ngx_http_validate_host call with custom validate_dns_identifier function implementing RFC 1123 validation with wildcard support |
| src/acme/solvers/tls_alpn.rs | Removes ngx_http_validate_host dependency, adds ASCII validation for DNS identifiers in TLS-ALPN solver |
| t/acme_conf_certificate.t | Adds test cases for invalid server name patterns |
| README.md | Updates minimum NGINX version requirement from 1.25.0 to 1.22.0 |
| .github/workflows/ci.yaml | Updates CI to test against NGINX 1.22 as the minimum supported version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bavshin-f5
force-pushed
the
nginx-1.29.4-compat
branch
from
fdb2ab9 to
a630129
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xeioex
approved these changes
Dec 5, 2025
The signature of ngx_http_validate_host has changed in NGINX 1.29.4, breaking the build of the module. Instead of continuing to abuse an internal API and wrapping it with version check, this commit reimplements the validation in a more suitable for the module way. Notable differences from the previous behavior: - Minimal supported NGINX version is now aligned to the ngx crate: 1.22 - The new logic mostly follows ngx_http_validate_host behavior as of NGINX 1.29.4, and may reject some previously accepted values. - Wildcard DNS identifiers are now permitted. Some ACME servers allow validating wildcard identifiers with challenges other than dns-01.
ensh63
approved these changes
Dec 5, 2025
bavshin-f5
force-pushed
the
nginx-1.29.4-compat
branch
from
27bbdde to
3dfdc61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of ngx_http_validate_host has changed in NGINX 1.29.4, breaking the build of the module. Instead of continuing to abuse an internal API and wrapping it with version check, this commit reimplements the validation in a more suitable for the module way.
Notable differences from the previous behavior:
Minimal supported NGINX version is now aligned to the ngx crate: 1.22
The new logic mostly follows ngx_http_validate_host behavior as of NGINX 1.29.4, and may reject some previously accepted values.
Wildcard DNS identifiers are now permitted. Some ACME servers allow validating wildcard identifiers with challenges other than dns-01.