-
Notifications
You must be signed in to change notification settings - Fork 113
Add support for multiple gateways #3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: change/control-data-plane-split
Are you sure you want to change the base?
Add support for multiple gateways #3275
Conversation
8b7192b
to
33a4cb7
Compare
2e13294
to
efd9397
Compare
61c9184
to
896523a
Compare
896523a
to
0ff8cfa
Compare
c1dd270
to
d4dcee1
Compare
d4dcee1
to
c1dd270
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3275 +/- ##
===================================================================
- Coverage 89.74% 86.72% -3.02%
===================================================================
Files 109 125 +16
Lines 11150 14445 +3295
Branches 50 62 +12
===================================================================
+ Hits 10007 12528 +2521
- Misses 1083 1780 +697
- Partials 60 137 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -301,7 +310,7 @@ func TestValidateBackendTLSPolicy(t *testing.T) { | |||
Namespace: "test", | |||
}, | |||
Spec: v1alpha3.BackendTLSPolicySpec{ | |||
TargetRefs: targetRefNormalCase, | |||
TargetRefs: targetRefInvalidKind, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this change not affect the outcome of the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how this test was passing before, this is a valid case where type is invalid
, the normal case targetRef kind was secret
which was the allowed type for cert ref kind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a bug? Could be worth an investigation (out of scope for this, but could make a note of it to revisit after this is done).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, let me make a note of it!
func TestBindRoutesToListeners(t *testing.T) { | ||
t.Parallel() | ||
g := NewWithT(t) | ||
|
||
g.Expect(func() { | ||
bindRoutesToListeners(nil, nil, nil, nil) | ||
}).ToNot(Panic()) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test case really needed? I know you're probably just trying to get coverage on the panic line, but is it even possible for us to call it like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is possible to call it like this. This was just for coverage and also for the fact that we do have events with no gateways to update so wanted to be cautious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work.
I think once we get conformance tests working and we can run our full suite of all tests, we can get a better feeling of any issues that may have arisen.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users want to be able to configure multiple gateways
Solution: Allows users to configure multiple gateways
Testing:
Manual testing: tracking it here
Closes #3219
Closes #3213
Closes #1443
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.