Skip to content

Conversation

@dareste
Copy link
Collaborator

@dareste dareste commented Jan 9, 2026

Proposed changes

  • The entitlement information is now included in the manifest.json.
  • The container lookup is done via substring match rather than exact match.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@dareste dareste requested review from Copilot and mrajagopal January 9, 2026 16:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds entitlement information to the manifest.json output and improves container matching flexibility by switching from exact name matching to substring matching for ingress containers.

Changes:

  • Added Entitlement field to the Manifest struct and populated it from entitlement/payload.json
  • Changed container name matching from exact match (container.Name == "nginx-ingress") to substring match (strings.Contains(container.Name, "ingress"))
  • Simplified entitlement file path from namespace-specific to a single payload.json file

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
pkg/jobs/nic_job_list.go Updated container matching logic to use substring matching and simplified entitlement file path
pkg/data_collector/data_collector.go Added entitlement field to manifest structure and logic to read/parse entitlement data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dareste dareste merged commit 0ceacd8 into main Jan 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants