Tests: added add_header/add_trailer field sanitization test.#58
Draft
louzt wants to merge 2 commits into
Draft
Conversation
Author
|
Companion nginx/nginx draft: nginx/nginx#1414 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the standalone nginx-tests regression for add_header and add_trailer sanitization.
Why
The companion test now covers the maintainer concern raised in review: invalid static field names in add_header/add_trailer should not be serialized either.
That keeps the test aligned with the direct upstream C draft instead of only checking CRLF in values.
What changed
X:Badfield name;Validation
Risks / Follow-ups
This test intentionally follows the current draft policy: sanitize bad values in place via a copy and skip bad names entirely. If upstream chooses a different late response-filter policy, the assertions should be updated to match that final design.