Miscellaneous fixes#163
Merged
Merged
Conversation
xeioex
requested changes
Jun 14, 2025
Change ngx::core::NGX_CONF_ERROR to *mut c_char and ensure that the pointer has no provenance in a way that is compatible with the current MSRV (1.79.0). Add ngx::core::NGX_CONF_OK constant for completeness.
Refuse to compile if the NGX_ALIGNMENT value detected or specified while building nginx is insufficient.
- mismatched_lifetime_syntaxes - clippy::uninlined_format_args
This allows to complete the linting and format checks on MSRV failure.
xeioex
approved these changes
Jun 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some commits from my allocators feature branch that are not related to the allocator-api or shared memory and can be reviewed independently.