fix(examples): generate more portable Makefiles#273
Merged
Conversation
The change should resolve our intermittent CI issues caused by absence of .PHONY in NMAKE.
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust example build Makefile generation to be more portable across different make implementations, addressing intermittent CI failures on NMAKE where .PHONY is not reliably supported.
Changes:
- Emit a single pseudotarget (
.NGX_RUST_PHONY) once per generated Makefile fragment. - Make each Rust build artifact depend on that pseudotarget so
cargo rustcis invoked unconditionally without relying on.PHONY.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ensh63
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change should resolve our intermittent CI issues caused by absence of .PHONY in NMAKE.
Tested: NMAKE 14.44, GNU Make 4.4.1, GNU Make 3.81, bmake 20230711, pdpmake 2.0.4,
SUNOracle™ make.