Skip to content

Release tarball target - #1105

Open
xeioex wants to merge 3 commits into
nginx:masterfrom
xeioex:release_tarball
Open

Release tarball target#1105
xeioex wants to merge 3 commits into
nginx:masterfrom
xeioex:release_tarball

Conversation

@xeioex

@xeioex xeioex commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

VadimZhestikov
VadimZhestikov previously approved these changes Aug 11, 2026

@VadimZhestikov VadimZhestikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Git-based release tarball generation and removes obsolete Mercurial infrastructure.

Changes:

  • Adds release creation, checksum, and build verification targets.
  • Configures archive exclusions and generated-file ignores.
  • Migrates revision metadata generation from Mercurial to Git.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
misc/GNUmakefile Adds release and verification targets.
auto/make Replaces Mercurial revision lookup and removes dist.
.hgtags Removes obsolete Mercurial tags.
.hgignore Removes obsolete Mercurial ignores.
.gitignore Ignores generated release artifacts.
.gitattributes Excludes development files from archives.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread auto/make Outdated
Comment thread auto/make Outdated
xeioex added 2 commits August 12, 2026 15:20
The "dist" target invoked "hg archive" and has been broken since the
migration to git.  For the same reason ts/COMMITHASH ended up empty in
every njs-types package published after the migration.

The .hgignore and .hgtags files are stale as well.
Add .gitattributes with "export-ignore" attributes, so that agent
instructions, CI configuration and the release machinery are not part
of the tarballs created by "git archive", including the ones GitHub
generates for a tag.
VadimZhestikov
VadimZhestikov previously approved these changes Aug 12, 2026

@VadimZhestikov VadimZhestikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

"make -f misc/GNUmakefile release" packages a tag into a
njs-<version>.tar.gz tarball with a checksum file.

The optional "release-check" target builds the extracted tarball.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants