Restore Github Actions #36
Merged
+137
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneetsarna
commented
Jun 10, 2025
|
NOTE: This does not have the swagger updates yet. Will add those as a follow up. |
puneetsarna
force-pushed
the
ps-dev-actions-test
branch
from
a23c0e8 to
ee270e3
Compare
|
Please add a flag for adding --debug to |
puneetsarna
force-pushed
the
ps-dev-actions-test
branch
4 times, most recently
from
3140756 to
8bfcd30
Compare
This is the new deployment that will now be used to test the Github action.
We don't have the test infrastructure fully set up to handle some of this yet. For now, we can just proxy pass to an upstream on localhost and update it down the road.
Now that we are using localhost as an upstream we need to make sure that the test to pass traffic checks for the correct headers based on the new config.
These are newer and recommended for use, especially for OIDC.
Azure CLI does not support wget from within the container for its action so swapping the invocations entirely with curl instead.
This flag, turned off by default, can be enabled by the customer to debug their Azure CLI invocations.
puneetsarna
force-pushed
the
ps-dev-actions-test
branch
from
8bfcd30 to
835b0f9
Compare
kuthiala
approved these changes
Jun 10, 2025
|
README and mention RBAC |
- Update the referenced nginx actions to 0.3.1 as cert actions do not work for 0.3.0. - Add an excerpt around Azure RBAC describing the access that the service principal will need in order for the action to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.