package tools => package crossplane #125
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When you import this package, the gopls language server reports the following error:
This doesn't actually affect usage, it's just kind of annoying since there's no way to disable this error:
This PR:
tools
tocrossplane
This will eliminate the errors since they're now the same package and refer to non-main packages. This should be a no-op, it just fixes the IDE errors.
Calling
go mod tidy
will still download these tools (you'll notice no changes togo.mod
orgo.sum
) and with the build (go:build tools
) constraint, they won't be included in any built binary.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
)