Skip to content

package tools => package crossplane #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

matthewmueller
Copy link
Contributor

@matthewmueller matthewmueller commented Oct 20, 2024

Proposed changes

When you import this package, the gopls language server reports the following error:

found packages crossplane (analyze.go) and tools (tools.go) in $GOPATH/pkg/mod/github.com/nginxinc/nginx-go-crossplane@v0.4.63go list

This doesn't actually affect usage, it's just kind of annoying since there's no way to disable this error:

CleanShot 2024-10-19 at 21 03 22@2x

This PR:

  • Changes the package from tools to crossplane
  • Changes the imports themselves to non-main packages

This will eliminate the errors since they're now the same package and refer to non-main packages. This should be a no-op, it just fixes the IDE errors.

Calling go mod tidy will still download these tools (you'll notice no changes to go.mod or go.sum) and with the build (go:build tools) constraint, they won't be included in any built binary.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

Sorry, something went wrong.

@matthewmueller matthewmueller requested a review from a team as a code owner October 20, 2024 02:05
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.08%. Comparing base (eaaaa89) to head (608c801).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   76.63%   76.08%   -0.55%     
==========================================
  Files          27       27              
  Lines        1164     1451     +287     
==========================================
+ Hits          892     1104     +212     
- Misses        216      291      +75     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ornj ornj merged commit 77d7a05 into nginxinc:main Oct 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants