Skip to content

Moved inline code to be on new line if needed #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/449

Before:
Screenshot 2025-04-22 at 7 55 49 AM

After:
Screenshot 2025-04-22 at 7 55 38 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Apr 22, 2025
@lamATnginx lamATnginx self-assigned this Apr 22, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner April 22, 2025 15:02
Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM locally.

We didn't get around to triaging this afaik, are we happy with this as the behaviour? Or is it okay to split something like this across multiple lines?

@lamATnginx
Copy link
Collaborator Author

Personally, for the sake of being able to copy effortlessly, yes. But not sure if it aligns with MF. Thoughts @danielledeleo?

@danielledeleo
Copy link
Contributor

What happens when the container isn't long enough?

@danielledeleo
Copy link
Contributor

I like having the flexibility to break. If writers don't want a break, then they can inject their own newline. I have played with this myself as well.

@lamATnginx lamATnginx marked this pull request as draft April 24, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants