MF: Use css for data-mf instead of js #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Playwright visual snapshot differences were detected.View the Playwright report |
✅ Deploy Preview will be available once build job completes!
|
danielledeleo
requested changes
May 16, 2025
❌ Playwright visual snapshot differences were detected.View the Playwright report |
❌ Playwright visual snapshot differences were detected.View the Playwright report |
❌ Playwright visual snapshot differences were detected.View the Playwright report |
lamATnginx
reviewed
May 19, 2025
lamATnginx
approved these changes
May 19, 2025
nginx-jack
force-pushed
the
data-mf-css
branch
2 times, most recently
from
793c845 to
bb7d3b6
Compare
nginx-jack
force-pushed
the
data-mf-css
branch
2 times, most recently
from
71fc686 to
bb8abbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the primary
data-mfbased theme switching to css instead of js.This should slightly increase initial render time (mostly on oldframe), since the css can load before the js.
This will also make it a little easier to remove all the theme switches later since
data-mfshould now be a reliable way to identify old/new components.This needs a good regression pass.
Small matching pr on documentation to fix redocly with this method of switching.
nginx/documentation#563