-
Notifications
You must be signed in to change notification settings - Fork 1
Lab1, 2 and 3 changes #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple of suggestions, but everything I reviewed looked technically correct.
We should standardize the labs on how we refer to Feature e.g lowercase
vs. Camel Case
. We (all of us) tend to use both Nginx and NGINX without distinction.
Also, it turns out only "old people" use double spaces after a sentence because they learned to type on typewriters or word processors and not computers. The standard accepted format is one space after a sentence on anything destined to be printed or online. I do this a lot too... it's easy enough to search for the double space and replace it.
Other than these small suggestions, I think we are good to publish these three labs!
Proposed changes
lab1, lab2 and lab3 content added.