Skip to content

Lab1, 2 and 3 changes #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 7, 2025
Merged

Lab1, 2 and 3 changes #12

merged 17 commits into from
Jan 7, 2025

Conversation

sdutta9
Copy link
Collaborator

@sdutta9 sdutta9 commented Jan 6, 2025

Proposed changes

lab1, lab2 and lab3 content added.

Copy link
Collaborator

@apcurrier apcurrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of suggestions, but everything I reviewed looked technically correct.

We should standardize the labs on how we refer to Feature e.g lowercase vs. Camel Case. We (all of us) tend to use both Nginx and NGINX without distinction.

Also, it turns out only "old people" use double spaces after a sentence because they learned to type on typewriters or word processors and not computers. The standard accepted format is one space after a sentence on anything destined to be printed or online. I do this a lot too... it's easy enough to search for the double space and replace it.

Other than these small suggestions, I think we are good to publish these three labs!

@sdutta9 sdutta9 merged commit cb77334 into main Jan 7, 2025
1 check failed
@sdutta9 sdutta9 deleted the sd branch January 7, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants