Skip to content

Conversation

@rg-lahcene
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, when you select a text or anything inside the dialog and release the selection outside the dialog ( in the backdrop), this will close the dialog as it handles the release of the mouse (selection) as click event.

Issue Number: #129

What is the new behavior?

Selecting a elements inside the dialog and then releasing the selecting in the backdrop does not close the dialog
Having a text selected then clicking in the backdrop closes the dialog if the enableClose is set to false.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@rg-lahcene rg-lahcene force-pushed the fix/backdrop-close-issue-on-select branch from c04f847 to 54908f2 Compare December 2, 2024 13:52
@NetanelBasal NetanelBasal merged commit a138288 into ngneat:master Dec 2, 2024
4 checks passed
@rg-lahcene
Copy link
Author

rg-lahcene commented Dec 2, 2024

@NetanelBasal Thanks for quicly reviewing the PR, is there any additional step to do inorder to release this fix?

@NetanelBasal
Copy link
Member

Yes, I'll release it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants