Skip to content

docs: ✏️ byTestId DOM selector#726

Merged
NetanelBasal merged 2 commits intongneat:masterfrom
chimurai:docs-byTestId
Sep 13, 2025
Merged

docs: ✏️ byTestId DOM selector#726
NetanelBasal merged 2 commits intongneat:masterfrom
chimurai:docs-byTestId

Conversation

@chimurai
Copy link
Contributor

@chimurai chimurai commented Sep 13, 2025

fixes: #380

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[x] Other... Please describe: Add missing `byTestId` unit tests

What is the current behavior?

byTestId is not documented: https://ngneat.github.io/spectator/docs/queries#dom-selector

Screenshot 2025-09-13 at 14 53 07

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

byTestId was added in #32

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@chimurai chimurai changed the title docs: ✏️ add byTestId DOM selector docs: ✏️ byTestId DOM selector Sep 13, 2025
@NetanelBasal NetanelBasal merged commit 549c63c into ngneat:master Sep 13, 2025
3 checks passed
@chimurai chimurai deleted the docs-byTestId branch September 13, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOM Query by Custom Attribute

2 participants

Comments