Remove all remaining log15 references, use slog.Logger everywhere #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inconshreveable
approved these changes
Jun 3, 2025
Contributor
inconshreveable
left a comment
inconshreveable
left a comment
There was a problem hiding this comment.
lgtm! ty for paying down some of the debt in the legacy package!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #203 we removed the public uses of
log15, but still had a few references hanging around internally.None of them seemed overtly difficult to remove, so I went through and cleaned them up.
This was mainly a rote replacement of
log15.Loggerto*slog.Logger, andlog15.Logger.Newtoslog.Logger.Withwith only two exceptions:github.com/inconshreveable/log15/v3/ext.RandID(). These becamefmt.Sprintf("%x", rand.Uint64()), which I think gives us something pretty similar overall.netx.LoggedConnembedded thelog15.Loggerinterface; slog doesn't have an interface, so I manually added the correctInfo,Warn, andErrormethod signatures insteadI also had to clean up the
examplesgo.moda little beforego mod tidythere worked, but I think I got that right.Overall, I think this is a straightforward refactor