Skip to content

Conversation

@jonstacks
Copy link
Contributor

What

I was looking specifically for the client.addr and didn't see it being logged anywhere. We were previously logging this in the ngrok-operator project when we were handling dialing the upstream and joining connections on our own. Now that we are using an endpoint forwarder to clean up code in the ngrok-operator, we no longer see these logs messages when increasing log verbosity.

How

Inside handleProxy seemed like the most reasonable place to log this. It still feels like there might be a little bit of overlap with

s.Debug("tunnel Accept", "reqType", reqType, "remoteAddr", s.remoteAddr)
. However, we don't have the client.addr there, so we can't add it there.

I'm hoping this will be generally useful, but if we don't think it will be, we can close this.

I was looking specifically for the client.addr and didn't see it being
logged anywhere. We were previously logging this in the ngrok-operator
project when we were handling dialing the upstream and joining
connections on our own. Now that we are using an endpoint forwarder to
clean up code in the ngrok-operator, we no longer see these logs
messages when increasing log verbosity.
@jonstacks jonstacks self-assigned this Jul 28, 2025
@jonstacks jonstacks merged commit 68351cc into main Aug 7, 2025
2 checks passed
@jonstacks jonstacks deleted the remote-addr-logging branch August 7, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants