feat: Increase logging around proxy conn #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I was looking specifically for the
client.addrand didn't see it being logged anywhere. We were previously logging this in the ngrok-operator project when we were handling dialing the upstream and joining connections on our own. Now that we are using an endpoint forwarder to clean up code in the ngrok-operator, we no longer see these logs messages when increasing log verbosity.How
Inside
handleProxyseemed like the most reasonable place to log this. It still feels like there might be a little bit of overlap withngrok-go/internal/tunnel/client/raw_session.go
Line 167 in 15e612c
client.addrthere, so we can't add it there.I'm hoping this will be generally useful, but if we don't think it will be, we can close this.