Convert interfaces into concrete structs#240
Draft
zombiezen wants to merge 3 commits intongrok:mainfrom
Draft
Conversation
Part of AGENT-445
Also copy memory to avoid having fields race or allowing user modification. Part of AGENT-445
zombiezen
commented
Apr 20, 2026
| // EndpointForwarder. | ||
| // Endpoint is the interface implemented by both | ||
| // [*EndpointListener] and [*EndpointForwarder]. | ||
| type Endpoint interface { |
Contributor
Author
There was a problem hiding this comment.
I was hacking on some other code over the weekend, and realized there's a better way of representing fixed sets of types like this: https://bsky.app/profile/zombiezen.com/post/3mjvmecvd5k26
(Reworking Endpoint to use this and implement some common methods is left as an exercise to the reader.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change and should not be merged without a major version bump and a migration strategy from v2.
Also fix race condition in
AgentSession.Part of AGENT-445