Open
Conversation
bmpngrok
reviewed
Apr 20, 2026
Contributor
bmpngrok
left a comment
bmpngrok
left a comment
There was a problem hiding this comment.
Some backcompat concerns with this, plus some minor code cleanup. If I'm missing something and the backcompat concern isn't valid, I can likely kick this to an Approve, but I figured we should talk first about it
| a.mu.RLock() | ||
| sess := a.sess | ||
| a.mu.RUnlock() | ||
| if sess == nil { |
Contributor
There was a problem hiding this comment.
Not your fault, but this is yet another race condition with this design
bmpngrok
approved these changes
Apr 24, 2026
Contributor
bmpngrok
left a comment
bmpngrok
left a comment
There was a problem hiding this comment.
I think you're good to ship this here
| } | ||
|
|
||
| func (s *reconnectingSession) PatchTunnelState(tunnelID string, name, description, metadata *string, poolingEnabled *bool) error { | ||
| if sess := s.firstSession(); sess != nil { |
Contributor
There was a problem hiding this comment.
This should probably technically be locked to avoid the session disappearing. I think. I'm honestly okay with you punting it if we get onto a v3 Go SDK sooner rather than later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds Update and UpdateUpstream to EndpointForwarder, allowing callers to mutate a running endpoint's metadata (name, description, metadata, pooling) and upstream URL without tearing down and rebinding the tunnel