Skip to content

Commit ad3380d

Browse files
authored
Add better kubebuilder type annotations to some status condition fiel… (#728)
Add better kubebuilder type annotations to some status condition fields for consistency
1 parent 2eb4378 commit ad3380d

File tree

4 files changed

+14
-0
lines changed

4 files changed

+14
-0
lines changed

api/ingress/v1alpha1/domain_types.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@ type DomainStatus struct {
8888
CertificateManagementStatus *DomainStatusCertificateManagementStatus `json:"certificateManagementStatus,omitempty"`
8989

9090
// Conditions represent the latest available observations of the domain's state
91+
// +listType=map
92+
// +listMapKey=type
93+
// +kubebuilder:validation:MaxItems=8
9194
Conditions []metav1.Condition `json:"conditions,omitempty"`
9295
}
9396

api/ingress/v1alpha1/ippolicy_types.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ type IPPolicyStatus struct {
7171
ID string `json:"id,omitempty"`
7272

7373
// Conditions represent the latest available observations of the IP policy's state
74+
// +listType=map
75+
// +listMapKey=type
76+
// +kubebuilder:validation:MaxItems=8
7477
Conditions []metav1.Condition `json:"conditions,omitempty"`
7578

7679
Rules []IPPolicyRuleStatus `json:"rules,omitempty"`

helm/ngrok-operator/templates/crds/ingress.k8s.ngrok.com_domains.yaml

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

helm/ngrok-operator/templates/crds/ingress.k8s.ngrok.com_ippolicies.yaml

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)