Skip to content

Conversation

@jonstacks
Copy link
Collaborator

What

Having ngrokAPICommon caused more problems than I think it solved. The code is messier for having it with having to mix & match struct initialization with setting values on the spec afterwards.

How

With the removal of edges, we have far fewer places where we are using this struct, so it seems like a good idea to get rid of it now.

Breaking Changes

No

@github-actions github-actions bot added area/controller Issues dealing with the controller size/L Denotes a PR that changes 100-499 lines labels Nov 4, 2025
This caused more problems than I think it solved. The code is messier for having it

Signed-off-by: Jonathan Stacks <[email protected]>
@jonstacks jonstacks force-pushed the remove-ngrok-api-common branch from 60f6f9c to cd5b9c7 Compare December 3, 2025 17:33
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.99%. Comparing base (e8d5d7d) to head (505a720).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/managerdriver/domains.go 50.00% 2 Missing ⚠️
cmd/api-manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   48.74%   48.99%   +0.25%     
==========================================
  Files          95       95              
  Lines       10600    10594       -6     
==========================================
+ Hits         5167     5191      +24     
+ Misses       5074     5044      -30     
  Partials      359      359              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonstacks jonstacks marked this pull request as ready for review December 3, 2025 19:17
@jonstacks jonstacks requested a review from a team as a code owner December 3, 2025 19:17
@jonstacks jonstacks added this pull request to the merge queue Dec 3, 2025
Merged via the queue into ngrok:main with commit 0b7b699 Dec 3, 2025
11 checks passed
@jonstacks jonstacks deleted the remove-ngrok-api-common branch December 3, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller Issues dealing with the controller size/L Denotes a PR that changes 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants