Skip to content

Conversation

@alex-bezek
Copy link
Collaborator

…st transition time change a lot

What

Stops setting this ready reason arbitrarily

How

This currently sets this condition on each reconciliation
Because it's normally true and this sets it to false, it changes the last transition timestamp

Breaking Changes

Are there any breaking changes in this PR?

@alex-bezek alex-bezek requested a review from a team as a code owner November 12, 2025 04:34
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines area/controller Issues dealing with the controller and removed size/M Denotes a PR that changes 30-99 lines labels Nov 12, 2025
@jonstacks jonstacks added this to the controller-0.19.1 milestone Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.77%. Comparing base (f681a05) to head (242bf45).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   48.81%   48.77%   -0.05%     
==========================================
  Files          95       95              
  Lines       10603    10600       -3     
==========================================
- Hits         5176     5170       -6     
- Misses       5069     5072       +3     
  Partials      358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonstacks jonstacks added this pull request to the merge queue Nov 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2025
@jonstacks jonstacks added this pull request to the merge queue Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2025
@jonstacks jonstacks added this pull request to the merge queue Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2025
@jonstacks jonstacks added this pull request to the merge queue Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2025
@jonstacks jonstacks added this pull request to the merge queue Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2025
@jonstacks jonstacks added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 55d7c3d Nov 13, 2025
11 checks passed
@jonstacks jonstacks deleted the alex/remove-agent-endpoint-reconciling-reason branch November 13, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller Issues dealing with the controller

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants