Skip to content

Conversation

@jonstacks
Copy link
Collaborator

What

Releases a new version of the controller and a RC for the next helm chart

How

Bump the controller version and make a helm RC for the next release to verify it.

Breaking Changes

Yes, there are changes to how domains work in conjunction with endpoints. See #705 for details

  • makes the bindings string array only allow 1 value via the kube api {ngrok api only allows 1)
  • agentendpoints and cloudendpoints with kubernetes bindings no longer get domains created or domainRef status fields
  • agentendpoints and cloudendpoints now get created even if their domains are not ready. The big bug is that the condition changes made them not get created if the domain isn't ready.
  • this meant endpoints with invalid domains that won't get certs but could still be used over http wouldn't get created
  • kubernetes bound endpoints created via CRDs also got domain CRs created for their k8s bound domain. These won't go ready since their TLD is the k8s namespace and not a domain that is owned.

@jonstacks jonstacks self-assigned this Nov 14, 2025
@jonstacks jonstacks requested a review from a team as a code owner November 14, 2025 16:16
@github-actions github-actions bot added area/helm-chart Issues dealing with the helm chart area/release Issues relating to releases size/M Denotes a PR that changes 30-99 lines labels Nov 14, 2025
@github-actions
Copy link

👋 Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

@github-actions
Copy link

👋 Looks like there are changes in the VERSION file. Upon merge, a new release of the docker image will be created. Please make sure the version is updated appropriately.

@jonstacks jonstacks added this pull request to the merge queue Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.78%. Comparing base (55d7c3d) to head (bedecee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   48.79%   48.78%   -0.01%     
==========================================
  Files          95       95              
  Lines       10600    10600              
==========================================
- Hits         5172     5171       -1     
- Misses       5070     5071       +1     
  Partials      358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit 0f176d5 Nov 14, 2025
13 checks passed
@jonstacks jonstacks deleted the release-ngrok-operator-0.19.1-helm-chart-0.21.1 branch November 14, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm-chart Issues dealing with the helm chart area/release Issues relating to releases size/M Denotes a PR that changes 30-99 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants