Skip to content

Conversation

@jonstacks
Copy link
Collaborator

What

Promotes the 0.21.1-rc.1 RC to 0.21.1

How

Bump the helm chart version

Breaking Changes

Yes, there are changes to how domains work in conjunction with endpoints. See #705 for details

  • makes the bindings string array only allow 1 value via the kube api {ngrok api only allows 1)
  • agentendpoints and cloudendpoints with kubernetes bindings no longer get domains created or domainRef status fields
  • agentendpoints and cloudendpoints now get created even if their domains are not ready. The big bug is that the condition changes made them not get created if the domain isn't ready.
  • this meant endpoints with invalid domains that won't get certs but could still be used over http wouldn't get created
  • kubernetes bound endpoints created via CRDs also got domain CRs created for their k8s bound domain. These won't go ready since their TLD is the k8s namespace and not a domain that is owned.

@jonstacks jonstacks self-assigned this Nov 17, 2025
@jonstacks jonstacks requested a review from a team as a code owner November 17, 2025 20:57
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines area/helm-chart Issues dealing with the helm chart area/release Issues relating to releases and removed size/S Denotes a PR that changes 10-29 lines labels Nov 17, 2025
@github-actions
Copy link

👋 Looks like there are changes in the Helm Chart's Chart.yaml file. Upon merge, a new release of the helm chart will be created if the Chart's version was changed.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.70%. Comparing base (0f176d5) to head (3532d79).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   48.76%   48.70%   -0.06%     
==========================================
  Files          95       95              
  Lines       10600    10600              
==========================================
- Hits         5169     5163       -6     
- Misses       5069     5076       +7     
+ Partials      362      361       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonstacks jonstacks added this pull request to the merge queue Nov 17, 2025
Merged via the queue into ngrok:main with commit 15e015e Nov 17, 2025
13 checks passed
@jonstacks jonstacks deleted the release-helm-chart-0.21.1 branch November 17, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm-chart Issues dealing with the helm chart area/release Issues relating to releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants