Skip to content

Conversation

@jonstacks
Copy link
Collaborator

What

Mainly updates the version of go that we are using in our devshell and that we use to build the docker image. There is 1 caveat with this PR and that the version of go in the devshell is 1.25.4, while the version we are building and testing with is 1.25.5. This is because nixpkgs-unstable doesn't have 1.25.5 available yet and targeting staging is more trouble than its worth right now.

How

Running nix flake update and formatting the flake.nix with nixfmt ./flake.nix

Breaking Changes

Shouldn't be, primarily updates the go version from 1.24 -> 1.25.

@jonstacks jonstacks self-assigned this Dec 8, 2025
@jonstacks jonstacks requested a review from a team as a code owner December 8, 2025 22:05
@github-actions github-actions bot added area/controller Issues dealing with the controller area/ci Issues/PRs relating to CI area/devenv size/M Denotes a PR that changes 30-99 lines labels Dec 8, 2025
@jonstacks jonstacks force-pushed the stacks/dependency-updates branch from 014292b to fa1daab Compare December 8, 2025 22:30
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines and removed size/M Denotes a PR that changes 30-99 lines labels Dec 8, 2025
@jonstacks jonstacks marked this pull request as draft December 9, 2025 18:17
@jonstacks
Copy link
Collaborator Author

Moving to draft while we figure out the other updates needed

@jonstacks jonstacks force-pushed the stacks/dependency-updates branch from fa1daab to 29d6844 Compare December 11, 2025 18:57
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines and removed area/ci Issues/PRs relating to CI size/L Denotes a PR that changes 100-499 lines labels Dec 11, 2025
Running nix flake update. Also bump uber go mock to fix issue with 1.25

Signed-off-by: Jonathan Stacks <[email protected]>
@jonstacks jonstacks force-pushed the stacks/dependency-updates branch from 29d6844 to c17c08f Compare December 15, 2025 21:34
@github-actions github-actions bot added the area/ci Issues/PRs relating to CI label Dec 15, 2025
@jonstacks jonstacks marked this pull request as ready for review December 15, 2025 21:37
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.10%. Comparing base (a956d80) to head (c17c08f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   49.11%   49.10%   -0.01%     
==========================================
  Files          95       95              
  Lines       10557    10557              
==========================================
- Hits         5185     5184       -1     
+ Misses       5014     5011       -3     
- Partials      358      362       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonstacks jonstacks added this to the controller-0.20.0 milestone Dec 15, 2025
@jonstacks jonstacks added this pull request to the merge queue Dec 15, 2025
Merged via the queue into ngrok:main with commit 5bc61e5 Dec 15, 2025
12 checks passed
@jonstacks jonstacks deleted the stacks/dependency-updates branch December 15, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Issues/PRs relating to CI area/controller Issues dealing with the controller area/devenv size/M Denotes a PR that changes 30-99 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants