Skip to content

Conversation

@jonstacks
Copy link
Collaborator

Continues the work from #725

What

We have several places where we manage dependencies. We have some currently consumed via nix, some via github actions, some via Makefile, and naturally our go dependencies. Having to update our Makefile dependencies periodically as opposed to just running nix flake update like we already do for go version increases complexity. We're looking at moving many of these to nix and out of go tools where appropriate.

How

  • Updates the actions/checkout action from many various version to v6. Also removed specific setup actions for things we have in our nix flake already. As an example, we now run with the same version of chainsaw that runs locally as well as the same version of go(less places to update).
  • Removes bootstrap-tools make target as everything is now moved to nix.
  • Adds caching for our nix flake so that runs are faster
  • Cleans up a lot of the indirection in the Makefile
  • Helm and the helm-unittest plugin are now consumed via nix
  • controller-gen is also consumed from nixpkgs. This caused the version to update to a recent version. (We were quite behind on versions and needed to update some of the kubebuilder markers. This also changed how the role gets generated. It appears the newer version collapsed some of the similar kinds where applicable to make the overall document smaller)
  • setup-envtest is now also pulled from nixpkgs.

Breaking Changes

There shouldn't be any. Most of this is all build related. The one place it could have impact is in the generated rbac since controller-gen gets updated. I looked thought it and it looked right though.

This also updates the version of controller-gen we are using to v0.19.0 and removes it from needing to be bootstrapped

Signed-off-by: Jonathan Stacks <[email protected]>
@jonstacks jonstacks self-assigned this Dec 10, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart area/ci Issues/PRs relating to CI area/devenv size/XL Denotes a PR that changes 500-999 lines labels Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.92%. Comparing base (c9eb45f) to head (2955093).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   48.99%   48.92%   -0.08%     
==========================================
  Files          95       95              
  Lines       10594    10594              
==========================================
- Hits         5191     5183       -8     
- Misses       5044     5049       +5     
- Partials      359      362       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonstacks jonstacks changed the title Stacks/less makefile dependencies chore(devenv): Move more tools into our nix devenv Dec 11, 2025
@jonstacks jonstacks marked this pull request as ready for review December 11, 2025 14:21
@jonstacks jonstacks requested a review from a team as a code owner December 11, 2025 14:21
@jonstacks jonstacks added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@jonstacks jonstacks added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 51e627c Dec 11, 2025
12 checks passed
@jonstacks jonstacks deleted the stacks/less-makefile-dependencies branch December 11, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Issues/PRs relating to CI area/controller Issues dealing with the controller area/devenv area/helm-chart Issues dealing with the helm chart documentation Improvements or additions to documentation size/XL Denotes a PR that changes 500-999 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants