-
Notifications
You must be signed in to change notification settings - Fork 36
chore(devenv): Move more tools into our nix devenv #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the version of controller-gen we are using to v0.19.0 and removes it from needing to be bootstrapped Signed-off-by: Jonathan Stacks <[email protected]>
Signed-off-by: Jonathan Stacks <[email protected]>
Signed-off-by: Jonathan Stacks <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 48.99% 48.92% -0.08%
==========================================
Files 95 95
Lines 10594 10594
==========================================
- Hits 5191 5183 -8
- Misses 5044 5049 +5
- Partials 359 362 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alex-bezek
reviewed
Dec 11, 2025
alex-bezek
reviewed
Dec 11, 2025
alex-bezek
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
Issues/PRs relating to CI
area/controller
Issues dealing with the controller
area/devenv
area/helm-chart
Issues dealing with the helm chart
documentation
Improvements or additions to documentation
size/XL
Denotes a PR that changes 500-999 lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work from #725
What
We have several places where we manage dependencies. We have some currently consumed via nix, some via github actions, some via Makefile, and naturally our go dependencies. Having to update our Makefile dependencies periodically as opposed to just running nix flake update like we already do for go version increases complexity. We're looking at moving many of these to nix and out of go tools where appropriate.
How
actions/checkoutaction from many various version to v6. Also removed specific setup actions for things we have in our nix flake already. As an example, we now run with the same version of chainsaw that runs locally as well as the same version of go(less places to update).bootstrap-toolsmake target as everything is now moved to nix.Breaking Changes
There shouldn't be any. Most of this is all build related. The one place it could have impact is in the generated rbac since controller-gen gets updated. I looked thought it and it looked right though.