Skip to content

Conversation

@alex-bezek
Copy link
Collaborator

What

There is an overarching user experience issue with the ngrok-operator. For simple use cases, users will typically reach for an Ingress object to create their ingress. Under the covers, the operator creates CRDs for its domain, cloud endpoint, and agent endpoint. While we do add lots of events and conditions to these CRs, they aren't clearly visibile to the user unless you know to describe those CRs or list all events.

While this is a general issue across all these CRDs, a commonly occuring issue that hits new users on free accounts is that they get provisioned a single reserved domain they can use. If they follow the quickstart and make up another domain, it errors and there is nothing helpful on the ingress object.

How

In the driver, we update the ingress status already and are already fetching domains. This enhances that code path to also push any Ready=False status conditions.

Breaking Changes

No

@alex-bezek alex-bezek requested a review from a team as a code owner December 15, 2025 21:36
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines area/controller Issues dealing with the controller and removed size/L Denotes a PR that changes 100-499 lines labels Dec 15, 2025
@jonstacks jonstacks added this to the controller-0.20.0 milestone Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 34.32836% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.16%. Comparing base (51e627c) to head (833d0e5).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/testutils/k8s-resources.go 0.00% 43 Missing ⚠️
cmd/api-manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   49.07%   49.16%   +0.09%     
==========================================
  Files          95       95              
  Lines       10594    10602       +8     
==========================================
+ Hits         5199     5213      +14     
+ Misses       5039     5030       -9     
- Partials      356      359       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex-bezek alex-bezek added this pull request to the merge queue Dec 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2025
@alex-bezek alex-bezek added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit 5a5f3ab Dec 16, 2025
11 checks passed
@alex-bezek alex-bezek deleted the alex/add-ingress-events-for-domain-conditions branch December 16, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller Issues dealing with the controller

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants