Push events to ingress about domain conditions via driver #730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There is an overarching user experience issue with the ngrok-operator. For simple use cases, users will typically reach for an Ingress object to create their ingress. Under the covers, the operator creates CRDs for its domain, cloud endpoint, and agent endpoint. While we do add lots of events and conditions to these CRs, they aren't clearly visibile to the user unless you know to describe those CRs or list all events.
While this is a general issue across all these CRDs, a commonly occuring issue that hits new users on free accounts is that they get provisioned a single reserved domain they can use. If they follow the quickstart and make up another domain, it errors and there is nothing helpful on the ingress object.
How
In the driver, we update the ingress status already and are already fetching domains. This enhances that code path to also push any Ready=False status conditions.
Breaking Changes
No