Alex/golangci linter for kubebuilder markers #731
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We noticed we have some invalid kubebuilder code gen markers. I fixed some in this other branch and made a minimal shell script to lint for things but it wasn't very good https://github.com/ngrok/ngrok-operator/pull/729/files
How
@jonstacks had the suggestion to build a golangci-lint plugin for this. From some research i found the controller-tools package has a way to get the markers.
This:
Breaking Changes
Maybe once we fix the validation issues
Validation
CI will fail as i haven't fixed the issues this found
https://book.kubebuilder.io/reference/markers/crd-validation