Skip to content

Conversation

@alex-bezek
Copy link
Collaborator

What

Removes redundant +kubebuilder:validation:Optional since they do nothing if omitempty is present

How

Delete the code, run make manifests and ensure no diffs

Breaking Changes

No

@alex-bezek alex-bezek requested a review from a team as a code owner December 16, 2025 20:52
@github-actions github-actions bot added the area/controller Issues dealing with the controller label Dec 16, 2025
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines label Dec 16, 2025
@jonstacks jonstacks added this to the controller-0.20.0 milestone Dec 18, 2025
@jonstacks jonstacks merged commit c46abc5 into alex/fix-bad-kubebuilder-markers Dec 18, 2025
2 checks passed
@jonstacks jonstacks deleted the cleanup-redundant-optional-markers branch December 18, 2025 17:08
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2025
* Fix invalid kubebuilder code gen markers

* Remove redundant optional markers (#735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller Issues dealing with the controller size/M Denotes a PR that changes 30-99 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants