Skip to content

Conversation

@jonstacks
Copy link
Collaborator

What

Adds CI tests that we can build off over time for testing installing multiple ngrok operators into a single cluster. Now that we have multiple installs working, we want to run tests to make sure we don't break that functionality.

How

Adds a new e2e-multi-namespace that runs after the regular e2e tests.

Breaking Changes

No, this is testing only.

@jonstacks jonstacks self-assigned this Dec 19, 2025
@github-actions github-actions bot added area/ci Issues/PRs relating to CI size/L Denotes a PR that changes 100-499 lines labels Dec 19, 2025
@jonstacks jonstacks requested a review from Copilot December 19, 2025 22:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds end-to-end tests for validating multiple ngrok operator installations in a single Kubernetes cluster, ensuring the multi-namespace functionality works correctly and doesn't regress over time.

Key changes:

  • New e2e-tests-multi-ns make target for running multi-namespace tests
  • New e2e-multi-namespace GitHub Actions job that runs after regular e2e tests
  • Comprehensive test suite in tests/chainsaw-multi-ns/ covering sanity checks and operator registration for two operators in separate namespaces

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/make/test.mk Adds new e2e-tests-multi-ns make target to run chainsaw tests from the chainsaw-multi-ns directory
tests/chainsaw-multi-ns/sanity-checks/*.yaml Validates that both operators (a and b) and their agents are running, and that ingress classes exist in respective namespaces
tests/chainsaw-multi-ns/operator-registration/chainsaw-test.yaml Tests that both operators successfully register with ngrok and receive proper IDs
tests/chainsaw-multi-ns/README.md Documents the test structure, prerequisites, and guidelines for writing new multi-namespace tests
.github/workflows/ci.yaml Adds new CI job for multi-namespace e2e testing with proper concurrency control and cleanup
.github/actions/build-and-test/action.yaml Updates KIND version from v0.26.0 to v0.30.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.15%. Comparing base (029fd83) to head (9792438).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   49.13%   49.15%   +0.01%     
==========================================
  Files          96       96              
  Lines       10604    10604              
==========================================
+ Hits         5210     5212       +2     
+ Misses       5037     5030       -7     
- Partials      357      362       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonstacks jonstacks force-pushed the stacks/multi-install-tests branch from 2615921 to 9792438 Compare December 19, 2025 22:44
@jonstacks jonstacks marked this pull request as ready for review December 19, 2025 22:54
@jonstacks jonstacks requested a review from a team as a code owner December 19, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Issues/PRs relating to CI size/L Denotes a PR that changes 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants