Skip to content

Conversation

@sabrina-ngrok
Copy link
Contributor

@sabrina-ngrok sabrina-ngrok commented Dec 22, 2025

Issue: #88

What

Create a helm value that can be used to pass in arbitrary annotations that get added to the cluster role.

How

  • values.yaml- Add definition for cluster role and adding the annotation
  • role.yaml rbac.yaml controller-rbac.yaml - Update main ClusterRole templates with annotations
  • editor/viewer subagents - Update editor/viewer ClusterRole templates with annotations
  • controller-rbac_test.yaml rbac_test.yaml - Add unit test for adding annotation to cluster role and confirming it was set

Unit tests testing

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: aggregate-cron-tabs-edit
  annotations:
    # Add these permissions to the "admin" and "edit" default roles.
    rbac.authorization.k8s.io/aggregate-to-admin: "true"
    rbac.authorization.k8s.io/aggregate-to-edit: "true"
  • Generate new version of README and snapshots

Breaking Changes

¯\(ツ)/¯

@sabrina-ngrok sabrina-ngrok requested a review from a team as a code owner December 22, 2025 18:56
@github-actions github-actions bot added area/helm-chart Issues dealing with the helm chart size/M Denotes a PR that changes 30-99 lines labels Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.06%. Comparing base (029fd83) to head (69d9225).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   49.13%   49.06%   -0.07%     
==========================================
  Files          96       96              
  Lines       10604    10604              
==========================================
- Hits         5210     5203       -7     
- Misses       5037     5041       +4     
- Partials      357      360       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm-chart Issues dealing with the helm chart size/M Denotes a PR that changes 30-99 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants