docs(store): add missing comma to createFeature example #4972
Conversation
✅ Deploy Preview for ngrx-io-v18 canceled.
|
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
modules/store/src/feature_creator.ts
Outdated
| * on(ProductsApiActions.loadSuccess, (state, { products }) => ({ | ||
| * ...state, | ||
| * products, | ||
| * }), |
There was a problem hiding this comment.
Thanks @DavidGoestemeier! Can you also add a missing closing bracket:
| * }), | |
| * })), |
There was a problem hiding this comment.
Great catch. Will do. Thanks!
Add a missing comma and bracket to the createFeature example in the store docs. Closes ngrx#4967
DavidGoestemeier
force-pushed
the
fix(#4967)-feature-creator-docs
branch
from
5ee7fbb to
b97da08
Compare
Add a missing comma and bracket to the createFeature example in the store docs. Closes ngrx#4967
|
I guess someone needs to clear yarn cache, because for some odd reason the install failed I could ofc make a empty commit or 2 amends with 1 force push... ah idk I need to work :( |
✅ Deploy Preview for ngrx-site-v19 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
markostanimirovic
changed the title
|
Thanks @DavidGoestemeier! |
3 participants
Add a comma to the reducer function parameter of the createFeature example in the store docs.
Closes #4967
Docs
What kind of change does this PR introduce?
What is the current behavior?
Fix faulty documenation of createFeature.
Closes #4967
What is the new behavior?
Just added a comma to fix the snippet.
Does this PR introduce a breaking change?