Cleanup serialization #1469
Open
Cleanup serialization #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They would have thrown exceptions if it was tried, so obviously not being used.
* Add some Serializable to classes that could potentially be serialized.
ngbrown
commented
Dec 3, 2017
| get { return targetType; } | ||
| get | ||
| { | ||
| if (targetType != null || targetTypeAssemblyQualifiedName == null) return targetType; |
There was a problem hiding this comment.
From #1425 (comment):
Why not restoring it in the deserialization constructor? (It will allow keeping it readonly by the way. The additional field could be avoided too.)
fredericDelaporte
approved these changes
Dec 6, 2017
| @@ -325,7 +325,7 @@ public static System.Type ClassForName(string name) | |||
| /// the method try to find the System.Type scanning all Assemblies of the <see cref="AppDomain.CurrentDomain"/>. | |||
| /// </remarks> | |||
| /// <exception cref="TypeLoadException">If no System.Type was found for <paramref name="classFullName"/>.</exception> | |||
| public static System.Type ClassForFullName(string classFullName) | |||
| public static System.Type ClassForFullName(string classFullName) | |||
There was a problem hiding this comment.
Reformatting this file is quite an unrelated change but well, let it be. (Checked with ?w=1, no unexpected changes.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a split-off of what was #1425.
This focuses only on the clean up of attributes and overloads. I used some Roslyn Analyzers that I wrote based on:
There are changes to visibility in the public API.
Possible breaking changes:
StatefulPersistenceContextandProxyObjectReferenceare now sealed.Configuration,DuplicateMappingException,ADOConnectionException,ConstraintViolationException,DataException,GenericADOException,LockAcquisitionException,SQLGrammarException,InvalidProxyTypeException.Serializableattribute but which were not actually serializable have no more the attribute. This impacts following classes:Mappings,NativeSQLQueryPlan,AbstractEventand all its descendants,EntityMetamodel,Propertyand all its descendants.ISerializableclasses lacking a de-serialization constructor have now one. It should be called by descendant classes own de-serialization constructor. This impacts following classes:CascadeStyle,SqlParseException,DetailedSemanticException,InvalidPathException,SemanticException,QueryExecutionRequestException,ParserException.