WIP Make IEntityPersister.IsTransient not async #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
force-pushed
the
persiterIsTransient
branch
from
be0796e to
3ce4cbe
Compare
hazzik
reviewed
Mar 13, 2019
bahusoid
force-pushed
the
persiterIsTransient
branch
from
3ce4cbe to
ac6c8fa
Compare
bahusoid
force-pushed
the
persiterIsTransient
branch
from
dcb6723 to
0205e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving cache check from
IEntityPersister.IsTransienttoForeignKeys.IsTransientSlowDefinitely for 6.0
I'm planning to split it in 2 PRs (extract DbTimestampType.UsePreparedStatement related changes to another PR). And it seems better to merge async regen changes as separate commit