Skip to content

NH-3724 - Added support for notification handlers #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Apr 10, 2019

Replaces #363

rjperes and others added 2 commits April 10, 2019 16:19
… most ADO.NET drivers)

Small fixes: - Base driver throws exception if a handler is passed to it - Drivers for .NET BCL classes just cast parameters to the expected types and will throw an exception if the type is wrong

Logic for InfoMessage event moved to DriverBase Exception is thrown if event is not found

Applied suggested fixes: removed unnecessary using directives and added . at the end of the exception message
@hazzik hazzik added this to the 6.0 milestone Apr 10, 2019
@hazzik
Copy link
Member Author

hazzik commented Jun 14, 2019

/rebase

@autorebase
Copy link

autorebase bot commented Jun 14, 2019

The rebase failed:

Not Found

To rebase manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/rebase rjperes-NH-3724
# Navigate to the new directory.
cd .worktrees/rebase
# Rebase and resolve the likely conflicts.
git rebase --interactive --autosquash master
# Push the new branch state to GitHub.
git push --force
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants