Skip to content

Add NUnit analyzers #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 27, 2024
Merged

Add NUnit analyzers #3492

merged 11 commits into from
Feb 27, 2024

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Feb 26, 2024 •
edited
Loading

  • Add NUnit.Analyzers
  • Fix NUnit2007: The actual value should not be a constant
  • Fix NUnit2041: The comparison constraint always fails as the actual and the expected value are not comparable
  • Fix NUnit2022: The type of the actual argument - 'IEnumerable<>' - has no property 'Count'
  • Fix NUnit2023: The type of the actual argument - 'bool' - can never be null
  • Fix other issues

@fredericDelaporte fredericDelaporte added this to the 5.6 milestone Feb 26, 2024
@hazzik hazzik enabled auto-merge (squash) February 27, 2024 00:14
@hazzik hazzik merged commit f938239 into nhibernate:master Feb 27, 2024
@hazzik hazzik deleted the nunit-analyzers branch February 27, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
c: Tests p: Minor r: Fixed t: Task
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.
2 participants
@hazzik @fredericDelaporte