Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mailers #2850

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Remove mailers #2850

merged 3 commits into from
Feb 12, 2025

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Jan 15, 2025 •
edited
Loading

This removes various references to ActionMailer and the mailer classes since they are no longer being used as we're sending emails using the GOV.UK Notify API directly now (#2841).

We can't remove the ApplicationMailer and stop requiring action_mailer/railtie until heartcombo/devise#5731 has been released.

@thomasleese thomasleese added the 🛠️ refactor Improving maintainability label Jan 15, 2025
@thomasleese thomasleese added this to the v1.5.0 milestone Jan 15, 2025
@thomasleese thomasleese changed the title Remove ActionMailer Remove ActionMailer references Jan 15, 2025
@thomasleese thomasleese changed the title Remove ActionMailer references Remove mailers Jan 15, 2025
@thomasleese thomasleese marked this pull request as ready for review January 15, 2025 16:13
tvararu
tvararu approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@tvararu tvararu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@thomasleese thomasleese force-pushed the mail-delivery-job branch 2 times, most recently from c40ef62 to 05bd1a7 Compare January 21, 2025 17:29
Base automatically changed from mail-delivery-job to main January 21, 2025 17:37
@tvararu tvararu temporarily deployed to mavis-pr-2850 January 29, 2025 16:08 Inactive
@thomasleese
Remove mailers
e9b7951 
This removes the unused mailer classses now that we're sending emails
using the GOV.UK Notify API directly.
@thomasleese
Remove mail-notify
51c8d08 
This Gem is no longer being used so we can safely remove it.
@thomasleese
Remove action_mailer
b159178 
We're no longer using `ActionMailer` to send emails so we can safely
remove code that references it.
@thomasleese thomasleese changed the base branch from main to v1.5.0-wip February 12, 2025 11:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thomasleese thomasleese merged commit 7548f94 into v1.5.0-wip Feb 12, 2025
13 checks passed
@thomasleese thomasleese deleted the remove-action-mailer branch February 12, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvararu tvararu tvararu approved these changes

Assignees
No one assigned
Labels
🛠️ refactor Improving maintainability
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasleese @tvararu