Skip to content

Switch to simpler review app styling etc#1191

Merged
colinrotherham merged 7 commits into
mainfrom
deploy-main
Apr 10, 2025
Merged

Switch to simpler review app styling etc#1191
colinrotherham merged 7 commits into
mainfrom
deploy-main

Conversation

@colinrotherham
Copy link
Copy Markdown
Contributor

@colinrotherham colinrotherham commented Mar 14, 2025

Description

This PR includes:

  1. Switch to simpler review app styling
  2. Removes "Install" and "About" guidance pages
  3. Deploys to GitHub pages automatically when merging into main

Point 3) means we can preview the latest nhsuk-frontend app between releases


Simple review app

Checklist

@colinrotherham colinrotherham force-pushed the deploy-main branch 2 times, most recently from a6ab677 to 86e9185 Compare March 14, 2025 17:20
Comment thread .github/workflows/deploy.yml
@anandamaryon1
Copy link
Copy Markdown
Contributor

I use the currently deployed frontend Github pages site as a reference often, perhaps it's only useful for me though?

But, I'd love to have a test/review/dev app for frontend, but probably not pointing to main, maybe a staging/review branch instead?

Perhaps we could have both? Or all three, with this proposal sitting in between? So a Prod, Review and Dev environment?

@colinrotherham
Copy link
Copy Markdown
Contributor Author

colinrotherham commented Apr 7, 2025

I use the currently deployed frontend Github pages site as a reference often, perhaps it's only useful for me though?

@anandamaryon1 To help support #1099 what do you think of simpler review app styling?

I've pushed it up, similar to https://govuk-frontend-review.herokuapp.com now

@colinrotherham colinrotherham changed the title Deploy automatically from main Switch to simpler review app styling etc Apr 7, 2025
@colinrotherham colinrotherham marked this pull request as ready for review April 7, 2025 12:06
@colinrotherham colinrotherham force-pushed the deploy-main branch 2 times, most recently from 00a0956 to 30541de Compare April 7, 2025 12:52
@colinrotherham colinrotherham changed the base branch from main to node-22 April 7, 2025 15:00
@anandamaryon1
Copy link
Copy Markdown
Contributor

Nice, a useful stepping stone to having a more useful review app for testing new work. And having the hero notice to alert users to what this is helpful too.

@colinrotherham If merged will this replace this PR: #1201? Or should we merge that one and adjust this one to be compatible ahead of merging it too?

Base automatically changed from node-22 to main April 8, 2025 15:28
@colinrotherham
Copy link
Copy Markdown
Contributor Author

@colinrotherham If merged will this replace this PR: #1201? Or should we merge that one and adjust this one to be compatible ahead of merging it too?

@anandamaryon1 I'd like to merge #1201 first and update this PR

Comment thread packages/components/skip-link/_skip-link.scss
@colinrotherham colinrotherham merged commit 1bde828 into main Apr 10, 2025
10 checks passed
@colinrotherham colinrotherham deleted the deploy-main branch April 10, 2025 09:08
@github-project-automation github-project-automation Bot moved this from Needs review to Done in Service Manual Sprint Board Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done - 2025

Development

Successfully merging this pull request may close these issues.

4 participants