Skip to content

Adopt GOV.UK Frontend packages structure#1217

Merged
colinrotherham merged 12 commits into
mainfrom
es-modules-packages
Jun 4, 2025
Merged

Adopt GOV.UK Frontend packages structure#1217
colinrotherham merged 12 commits into
mainfrom
es-modules-packages

Conversation

@colinrotherham
Copy link
Copy Markdown
Contributor

@colinrotherham colinrotherham commented Apr 4, 2025 •
edited
Loading

Closes #1351

@colinrotherham colinrotherham force-pushed the es-modules-gulp branch 2 times, most recently from 1d4eebb to f41dc5c Compare April 15, 2025 08:46
@colinrotherham colinrotherham force-pushed the es-modules-packages branch 2 times, most recently from 926f420 to eb7ef27 Compare April 15, 2025 08:53
@colinrotherham colinrotherham force-pushed the es-modules-gulp branch 2 times, most recently from 16bfc17 to 3d809cd Compare April 15, 2025 08:59
Base automatically changed from es-modules-gulp to main April 15, 2025 09:03
@colinrotherham colinrotherham changed the base branch from main to move-tests April 15, 2025 10:57
@colinrotherham colinrotherham force-pushed the move-tests branch 4 times, most recently from d4b1ec5 to 7e6d772 Compare April 16, 2025 16:26
Base automatically changed from move-tests to main April 22, 2025 12:24
@colinrotherham colinrotherham force-pushed the es-modules-packages branch 2 times, most recently from ebcb131 to 87a9b75 Compare April 22, 2025 13:37
@colinrotherham colinrotherham marked this pull request as ready for review April 22, 2025 13:42
@colinrotherham colinrotherham linked an issue Apr 24, 2025 that may be closed by this pull request
Update our file structure and build tooling to align with GOV.UK #1237
Closed
@colinrotherham colinrotherham changed the base branch from main to package-exports April 25, 2025 08:10
@colinrotherham colinrotherham force-pushed the es-modules-packages branch 3 times, most recently from b587287 to e19b4fe Compare April 25, 2025 08:48
@colinrotherham colinrotherham mentioned this pull request Jun 2, 2025
Merged
3 tasks
@colinrotherham colinrotherham force-pushed the es-modules-packages branch 3 times, most recently from 2b4fae3 to ee341d7 Compare June 3, 2025 12:29
@colinrotherham colinrotherham force-pushed the es-modules-packages branch 2 times, most recently from a869d87 to 791aa82 Compare June 3, 2025 13:32
@nhsuk nhsuk deleted a comment from sonarqubecloud Bot Jun 3, 2025
@colinrotherham colinrotherham force-pushed the es-modules-packages branch 2 times, most recently from 11048fb to 304faaa Compare June 3, 2025 13:55
MatMoore
MatMoore approved these changes Jun 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MatMoore MatMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

Hopefully this will make it easier to port stuff across.

@colinrotherham
Copy link
Copy Markdown
Contributor Author

colinrotherham commented Jun 3, 2025

Hopefully this will make it easier to port stuff across.

Up for discussion of course, but yeah makes it much easier to bring the ports into this repo if desired

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2025

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@colinrotherham
Copy link
Copy Markdown
Contributor Author

colinrotherham commented Jun 4, 2025

I've also followed alphagov/govuk-frontend#4091 and used scope @nhsuk for internal packages

Before

nhsuk-frontend-config
nhsuk-frontend-helpers
nhsuk-frontend-tasks

After

@nhsuk/frontend-config
@nhsuk/frontend-helpers
@nhsuk/frontend-tasks

This avoids potential "typosquatting" / dependency confusion (a bug existed once)

A variant of this attack is when a public package is registered with the same name of a private package that an organization is using. We strongly encourage using scoped packages to ensure that a private package isn’t being substituted with one from the public registry.

@colinrotherham colinrotherham merged commit 95e9436 into main Jun 4, 2025
13 checks passed
@colinrotherham colinrotherham deleted the es-modules-packages branch June 4, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MatMoore MatMoore MatMoore approved these changes

Assignees

No one assigned

Labels

💥 breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adopt GOV.UK Frontend packages structure Update our file structure and build tooling to align with GOV.UK

4 participants

@colinrotherham @MatMoore @sarawilcox @anandamaryon1