Add notification banner component#1408
Conversation
|
Could you add some screenshots? One question I have is whether the background should be white or the page background colour, the faded blue/grey. |
7401993 to
1b57550
Compare
1b57550 to
d932ca1
Compare
|
Other than cache issues in actions/cache#1621 it's all wired up now 🙌 E.g. Auto focus is working in notification-banner/success.html |
|
Looking good. I notice that, like the error summary, we have a visible focus outline on the success version. Shall we try to fix these, or wait for the GOV extension work to progress @colinrotherham? |
|
Ah I've come to like the focus outline, it only kicks in for alert roles (same as error summary) The focus outline is visible in GOV.UK Frontend too:
Other than the background colour (fixed) it seems like a sensible addition |
|
Ok fair enough 👍 |
|
After some discussion on slack we feel these should likely have a transparent background (page colour) to match how the error summary works. I've updated the screenshots in the initial PR to match. |
306be13 to
4a12e2e
Compare
|
@edwardhorsford I've updated this PR to target Should unblock you from installing it into the service manual website |
b58cb11 to
92af00e
Compare
colinrotherham
left a comment
There was a problem hiding this comment.
Thanks again for this @edwardhorsford
I've switched it back to v10.x by targetting main
This PR currently adds support for Nunjucks data-disable-auto-focus but it only works via the JavaScript config at the moment, similarly over in GOV.UK Frontend this same feature works in both Nunjucks and JavaScript
What shall we do?
I'm tempted to either drop support for Nunjucks data-disable-auto-focus or fix it and make sure we add it to Error Summary too so it's not left behind
9f5d3da to
f0764b7
Compare
|
|
@edwardhorsford This is now ready to go if you can have a look please @anandamaryon1 🙌 I've split out work to configure all components by either Nunjucks or JavaScript in: |





Adds a new component 'notification banner' adapted from GOV.UK Frontend.
Steps taken:
/govuk-frontend/src/govuk/components/nofication-banner, removing those we don't use.govuktonhsuknhsuk-success-colorsass variable.Default example:

Success example:
