Skip to content

Backport fix styles for button as link :visited when :active and :focus for v9.6.4 #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinrotherham merged 3 commits into from
Jul 10, 2025
+21 −8
Merged

Backport fix styles for button as link :visited when :active and :focus for v9.6.4 #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af9ab51
fix button styles for visited link buttons when active and focus fixe…
anandamaryon1 Jul 10, 2025
887598b
add changelog entry
anandamaryon1 Jul 10, 2025
afc0634
Bump version for v9.6.4 release
colinrotherham Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# NHS.UK frontend Changelog

## 9.6.4 - 10 July 2025

Note: This release was created from the `support/9.x` branch.

:wrench: **Fixes**

- [#1471: Fix styles for button as link :visited when :active and :focus](https://github.com/nhsuk/nhsuk-frontend/pull/1471)

## 9.6.3 - 19 June 2025

Note: This release was created from the `support/9.x` branch.
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nhsuk-frontend",
"version": "9.6.3",
"version": "9.6.4",
"description": "NHS.UK frontend contains the code you need to start building user interfaces for NHS websites and services.",
"engines": {
"node": "^20.9.0 || ^22.11.0"
Expand Down
15 changes: 10 additions & 5 deletions packages/components/button/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ $button-padding-left-right: 16px;
}

// Remove button shadow when pressed
&:active {
&:active,
&:active:focus {
box-shadow: none;
background-color: $nhsuk-button-active-color;
top: $button-shadow-size;
Expand Down Expand Up @@ -149,7 +150,8 @@ $button-padding-left-right: 16px;
}

// Set border for active state (no shadow)
&:active {
&:active,
&:active:focus {
background-color: $nhsuk-secondary-button-active-color;
border-color: $nhsuk-secondary-button-border-color;
border-radius: $button-border-radius;
Expand Down Expand Up @@ -210,7 +212,8 @@ $button-padding-left-right: 16px;
background-color: $nhsuk-reverse-button-hover-color;
}

&:active {
&:active,
&:active:focus {
background-color: $nhsuk-reverse-button-active-color;
}
}
Expand All @@ -224,7 +227,8 @@ $button-padding-left-right: 16px;
background-color: $nhsuk-warning-button-hover-color;
}

&:active {
&:active,
&:active:focus {
background-color: $nhsuk-warning-button-active-color;
}
}
Expand All @@ -238,7 +242,8 @@ $button-padding-left-right: 16px;
background-color: $nhsuk-login-button-hover-color;
}

&:active {
&:active,
&:active:focus {
background-color: $nhsuk-login-button-active-color;
}
}
Expand Down